-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Padrino (v. 0.15.3) fails to start with Ruby 3.3.0: uninitialized constant Padrino::Rackup (NameError) #2288
Comments
@achiurizo would this be fixed with a release from master? Would be great to cut a release that supports Ruby 3.3 |
Something to mention is that I am using the git repository as a source code, I mean, in my Gemfle it is as follows: |
@kimberlykeilymh thank you for the report! I've pushed out #2289 which should resolve this (adds
@nesquena we should do more testing after #2289 but after that I think we can go ahead and cut a release |
I went ahead and merged that change. Let us know if that fixes things for you. If everything is working as expected, we can do final testing and cut a release |
Thanks guys! The change fixed the bug with Although now I get this other error:
Is it also possible to check this error? I can open another issue and close this one if you want. |
@achiurizo hmm, looks like rack_options is nil rather than a hash now in the server start sequence |
@nesquena I built a Padrino app from scratch with limited changes to config (updating database) — using Edge release w/ the inclusion of Backup in the Gemspec results in the issue @kimberlykeilymh mentioned above.
Prior to using the Edge release, I was using the default release and included Backup using |
As a starting point, thanks @srolandmarshall I don't want to be too optimistic but it seems like part of this may just be a change to the way Rack parses the files. I had rack options default to {} on #2290 (branch nesquena-rack-options-fix) until achiu may have a chance to test end to end It's possible this would fix it, but also possible and likely there's larger changes to Rack that need to be adjusted in the core server startup sequence |
Checked it out, seemed to solve the problem on my end. Thanks for the quick patch @nesquena |
Great, thanks for testing! @achiurizo can you merge my PR, and @kimberlykeilymh can you try my patch as well and report back either now or after we merge to master |
Hi guys! Yes, that solved the problem and padrino is running without errors. Thanks very much for the fix! |
That's great news, thanks for testing! Since two of you confirmed, perhaps it's time to cut a new release soon |
Hi! Any news on a new release of Padrino? |
I'll push out a new release with these fixes within a week |
Okay I pushed out release 0.16.0.pre2 which appears compatible with latest Rack and Ruby - can one or two of you try this and report back confirming everything works as it should? @floriandejonckheere @achiurizo @kimberlykeilymh @srolandmarshall As soon as I get confirmations, I'll cut it as an official release! If anyone wants to help fix the CI to pass the tests fully, that would be appreciated as well 😅 |
Hi folks! Thanks for pushed out a new version!
|
Based on this part of the error:
I wonder if you could try adding the "puma" gem or thin to the Gemfile of your app, run bundle and then try starting it up again? Does that change anything? |
Something I forgot to mention is that we use WEBrick as a server, which is part of the server list. |
Trying with Puma and thin I got the same error |
Thanks @kimberlykeilymh for testing! I'm glad I did this as a pre release 😅 And once we figure out this issue, get all the tests passing, and confirm things are looking good, I'll push an official version |
@achiurizo Any idea what might be going on above? |
Pushed pre3 @kimberlykeilymh Can you try again with the latest pre3 release and confirm that everything works as expected now? |
Hi Nathan! @nesquena On the other hand, I had an error with this new version regarding the parameters received by the controller. In one of the forms we have fields nested in two levels that reach the controller in the following way:
But now those same parameters are obtained like this:
At the form level the name of the fields remains the same ( This would be for example for an Do you have any idea what could be happening? Is there some new definition in the framework that does not allow nesting in more than one level? Thanks in advance, |
Thanks so much for testing @kimberlykeilymh and catching the issue with nested form parameter processing. That seems like a bug. Before we release, we'll fix this so that it matches the original behavior If anyone can help investigate, and or write tests for this, or fix any other failing tests, that would be appreciated Before this next major release, we'll also need to fix all failing tests and test a number of apps work as expected. But glad we are making some progress 😊 |
Building on @kimberlykeilymh's issue, here's what I'm getting when I try to deploy to heroku running Ruby 3.2.5 NameError: uninitialized constant Rack::Server (NameError) class Server < Rack::Server (See full trace by running task with --trace) |
Can anyone help? I and ChatGPT are at a loss on how to fix this. I've just been trying to update my sinatra/padrino app to run on the latest heroku stack which runs 3.2.5 |
I definitely keep getting the same error and I'm stuck. /Users/rasheqrahman/.rvm/gems/ruby-3.2.5/gems/padrino-core-0.15.3/lib/padrino-core/server.rb:34:in `module:Padrino': uninitialized constant Rack::Server (NameError) class Server < Rack::Server |
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
Failure to start server using Ruby 3.3.0. Below is the stack trace.
What is the expected behavior?
Start the server without errors.
Which versions of Ruby, Padrino, Sinatra, Rack, OS are you using? Did this work in previous versions?
Ruby 3.3.0, Padrino 0.15.3, Ubuntu 23.10.
The text was updated successfully, but these errors were encountered: