Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several RFDs (183, 186, 188) missing from RFD site #84

Open
gjcolombo opened this issue Feb 6, 2024 · 2 comments
Open

Several RFDs (183, 186, 188) missing from RFD site #84

gjcolombo opened this issue Feb 6, 2024 · 2 comments

Comments

@gjcolombo
Copy link

Repro steps: While logged into the RFD site, browse the list of all RFDs in numerical order.

Expected: They're all there :)

Observed: Some RFDs are missing. 183, 186, and 188 are definitely affected, but there might be others. Trying to navigate directly to one of their URIs (https://rfd.shared.oxide.computer/rfd/0186) pops an error page with the following contents:

<!DOCTYPE html><html lang="en"><head><meta charSet="utf-8"/><meta name="viewport" content="width=device-width, initial-scale=1, viewport-fit=cover"/><title>Unhandled Thrown Response!</title></head><body><h1 style="font-family:system-ui, sans-serif;padding:2rem">404<!-- --> </h1><script>
              console.log(
                "💿 Hey developer👋. You can provide a way better UX than this when your app throws 404s (and other responses). Check out https://remix.run/guides/not-found for more information."
              );
            </script></body></html>
@augustuswm
Copy link
Contributor

augustuswm commented Feb 6, 2024 •
edited
Loading

Expanding this list to: 42, 149, 183, 186, 188, 199, 318

This matches the count of RFDs that I expect to be missing based on the list count vs the highest RFD number. I have suspicions that this is related to older RFDs that are still in Markdown failing to parse. Markdown should still be supported, and this is likely a bug in the RFD parser.

Verified that the above RFDs were not processed as jobs, with the exception of 318 which is likely failing for an unrelated reason.

@augustuswm
Copy link
Contributor

42, 149, 183, 186, 188, 199 being missing was due to a missed fallback check for Markdown readme files. This has been fixed and those RFDs should now all appear in the API.

RFD 318 is a different case and is indicative of a bug in the logic that decides between an RFD that is on the master branch and also has an individual branch. In this case. In this case it seems like the branch should be preferred as the RFD is erroneously on the master branch (it is still in discussion), but instead both the master branch scan and the individual branch scan are declining to process it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@augustuswm @gjcolombo