Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpmock 0.8.0-alpha.1 breaks generated mocks #904

Open
jayvdb opened this issue Sep 2, 2024 · 1 comment
Open

httpmock 0.8.0-alpha.1 breaks generated mocks #904

jayvdb opened this issue Sep 2, 2024 · 1 comment

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Sep 2, 2024

Just a heads up that the next version of httpmock will require some small changes.

I see one error and a deprecation

error[E0615]: attempted to take value of method `query_params` on type `&HttpMockRequest`
   --> libs/test-http-mocks/src/foo.rs:100:25
    |
100 |                     req.query_params
    |                         ^^^^^^^^^^^^ method, not a field
    |
help: use parentheses to call the method
    |
100 |                     req.query_params()
    |                                     ++

warning: use of deprecated method `httpmock::When::matches`: Please use the `is_true` and `is_false` function instead
  --> libs/test-http-mocks/src/bar.rs:80:29
   |
80 |                 Self(self.0.matches(|req| {
   |                             ^^^^^^^
@ahl
Copy link
Collaborator

ahl commented Sep 3, 2024

Thanks for this! We'll keep an eye on it as it get closer to a non-alpha version. PRs welcome here if you're interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants