Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddm: enable_stats smashes all errors into 500s #303

Open
rcgoodfellow opened this issue Jul 23, 2024 · 0 comments
Open

ddm: enable_stats smashes all errors into 500s #303

rcgoodfellow opened this issue Jul 23, 2024 · 0 comments
Labels
ddm Delay Driven Multipath

Comments

@rcgoodfellow
Copy link
Collaborator

This code smashes all errors to the enable_stats endpoint into 500s.

maghemite/ddm/src/admin.rs

Lines 382 to 386 in ef0edbb

.map_err(|e| {
HttpError::for_internal_error(format!(
"failed to start stats server: {e}"
))
})?,

It would be helpful to be more specific here, in particular if the underlay configuration has not gotten far enough along yet to enable stats, we'll probably want to return something more like a 503.

@rcgoodfellow rcgoodfellow added the ddm Delay Driven Multipath label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ddm Delay Driven Multipath
Projects
None yet
Development

No branches or pull requests

1 participant