Trim descriptions, so whitespace-only descriptions don't get passed through #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
charliepark
changed the title
|
I imagine it's a bit more work, but can we perhaps address this (oxidecomputer/omicron#4929) and set it to undefined if it's just whitespace. |
| const trimmedDescription = event.target.value.trim() | ||
| event.target.value = trimmedDescription | ||
| props.control._formValues.description = trimmedDescription | ||
| }} |
There was a problem hiding this comment.
I think blur is too specific of a place for this — shouldn't transform work? Or I guess that prevents you from ever typing whitespace. I'm thinking we should just not do this if this is the only way to do it. Ideally it would happen at submit time (which we might already be doing manually in a few paces), but I don't know of a way to wire this up at field level to happen on submit, which is at form level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For discussion …
This PR fixes an edge case with DescriptionFields. Currently, they can be created with an empty space (or some other combination of whitespace) as the only text in the description. This PR updates the DescriptionField, so that when it is blurred, the value is trimmed.
I like this approach, as it keeps the change scoped to the DescriptionField component, whereas if we handled it at the form layer, we'd need to add a function in each place in the app where we use the DescriptionField. This way, it's handled within the one file. That being said, forcing an update to
props.control._formValues.descriptionfeels off.If we move forward with it …
Closes #2515