Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder IDP form elements #2511

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Reorder IDP form elements #2511

wants to merge 1 commit into from

Conversation

charliepark
Copy link
Contributor

@charliepark charliepark commented Oct 21, 2024

So far, this branch is only modifying the create form, though once feedback is in, I'll modify the update form to match.

This addresses #2471, where Augustus proposed updating the IDP form to more logically group the various components. The main changes here are …

  • adding headers for the various sections
  • reordering the fields
  • adding a checkbox for signed requests, which then reveals the public cert / private key fields

Here's the updated layout …
Screenshot 2024-10-21 at 10 11 37 AM

… and with the "Signed requests" box checked …
Screenshot 2024-10-21 at 10 11 53 AM

I'm open to any other modifications; just opening this up for discussion and moving the ball down the field.

Closes #2471

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Oct 21, 2024 5:19pm

@david-crespo
Copy link
Collaborator

david-crespo commented Oct 21, 2024

Looks good. Noticed the section headings are the same size as the modal title, which seems too big, but I see you followed Firewall Rules, which is the same way. They're all text-sans-2xl (1.5625rem, so I tried text-sans-xl (1.125rem) and it's too small, which is presumably how I landed on 2xl for the sections. Need @benjaminleonard's input here — is there/should there be a heading in between those sizes?

@benjaminleonard
Copy link
Contributor

I'm trying to recall if we're using headings for any pane forms currently. It's a reasonable addition but there are broader implications in terms of rolling it out to every form that chunks the contents like this.

This might be a reason to move this into a full-page like the instance create form. What do you think? That might give us space to add some more inventive UI also.

@benjaminleonard
Copy link
Contributor

Just noticing you mentioned firewall rules - will explore what headings should look like there. I didn't have them in the original design but they are helpful. Not exactly sure what the distinction is but firewall rule is not something that should be converted to a full form right.

@david-crespo
Copy link
Collaborator

Yeah, the firewall rules form probably feels better in the context of the list. It would be a little jarring on its own page. The main problem with the form is the length, so I'm not sure a full page form would help much anyway, though I guess you could do something like putting target type and value pickers side by side. I wonder if there's room for a wider side modal form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] Reorganize IdP form
3 participants