[junit5.cm] handle just configurations from annotations #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan <stbischof@bipolis.org>
That depends - if we think that we might release them independently then yes, but I'm not sure whether that is currently possible? |
|
We should definitely add some new tests for the desired behaviour. |
|
would be great is you could add the tests |
* The annotation scanning for the ConfigurationExtension was being applied to early - test method configuration was available in BeforeEach methods * The configuration lifecycle was too long - by waiting for the ExtensionContext to close we could not restore configurations at the right time * The ConfigurationExtension relied on static state. This has been removed, apart from one static which must persist until deprecated methods can be removed Signed-off-by: Tim Ward <timothyjward@apache.org>
Add lifecycle testing and fixes for the ConfigurationExtension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: handle just configurations from annotations
@timothyjward the pom structure has one version for all bundles. should we switch to independent bundleversions. defind in parent-poms properties?