Skip to content
This repository has been archived by the owner on Dec 4, 2020. It is now read-only.

[Converter] Should custom rules/error handlers be applied in reverse order? #2974

Open
bjhargrave opened this issue Jan 18, 2019 · 3 comments
Assignees

Comments

@bjhargrave
Copy link
Member

Original bug ID: BZ#3106
From: @bosschaert
Reported version: R7

@bjhargrave
Copy link
Member Author

Comment author: @bosschaert

This issue comes from https://issues.apache.org/jira/browse/FELIX-6008

It's possible to create derived custom converters from an initial custom converter.
If we want to override some of the behaviour of the initial custom converter in the second level custom converter, the rules need to be applied in reverse order, otherwise they never get called. The same is true for the errorHandlers.

The spec doesn't seem to be very specific about the order in which custom rules and error handlers are invoked, especially for 2nd-level custom converter.

We should tidy up the spec on this point and also consider whether reversing is needed.

@bjhargrave
Copy link
Member Author

Comment author: @bjhargrave

CPEG call: For R8 consider adding methods to add rules at beginning of list to complement the existing methods which add at end of list.

@bjhargrave
Copy link
Member Author

Comment author: @bosschaert

Berlin F2F: this is a bug in the implementation and should just be fixed.

First all normal rules of the child need to be run, then all catchall rules. If the rules can't handle the conversion it should be delegated back to the parent.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants