Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Upgrade to rails 6 + authentication scheme #43

Open
JensDebergh opened this issue Feb 26, 2020 · 0 comments
Open

Proposal: Upgrade to rails 6 + authentication scheme #43

JensDebergh opened this issue Feb 26, 2020 · 0 comments

Comments

@JensDebergh
Copy link

Hey there!

I was wondering if you guys would be open to accept a pull request which does following things:

Proposal:

  • Upgrade to rails 6

Reason:

I'm using rails 6 and would like to use lines engine as it solves most of my problems, but I'm unable to since it is rails 5 only.

Proposal:

  • Step away from the predefined authentication scheme like devise you are using.

I don't mean directly removing devise as a whole but make it configurable by the user. Be it http authentication or custom authentication.

Reason

It seems unnecessary to bring in a complete new authentication scheme / dependencies + lines_user table if I already have a user table in my database.

I would propose to add a function call that lines calls when checking for authenticated users.

# Authentication scheme is handled and determined by the developer that uses the engine
authenticate -> { |username, password|  return true | false } 

Kind regards
Jens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant