-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for "finished span handler" #90
Labels
Comments
FinishedSpanHandler would also allow for a solution to #58 |
jcchavezs
added a commit
that referenced
this issue
Jul 14, 2019
jcchavezs
added a commit
that referenced
this issue
Aug 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are some cases where one might need to enable/disable tracing for certain children spans. For example, if I will write a bunch of files in a zip stream, I want to trace the call to S3 to list the files but not every single call to S3 to retrieve the content of the file. In such case I want to make a decision on what to record and what not based on rules in the spans.
For implementation reference we could have a look at brave: https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/handler/FinishedSpanHandler.java
Ping @basvanbeek @adriancole
The text was updated successfully, but these errors were encountered: