-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NullPointerException #52
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am getting the following error when using
play-zipkin-tracing
:toSpan
usesjoinSpan
https://github.com/openzipkin-contrib/play-zipkin-tracing/blob/master/play-zipkin-tracing/core/src/main/scala/brave/play/ZipkinTraceServiceLike.scala#L168But the problem is it also passes
contextOrFlags.context()
tojoinSpan
, which might benull
if no context was extracted.Would using
nextSpan(contextOrFlags)
, as suggested in brave, be a better choice?https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/Tracer.java#L160
The text was updated successfully, but these errors were encountered: