Investigate changes necessary to move to Python 3

[englehardt]

Python 2.7 is being slowly removed from the default installs of Ubuntu, we should investigate what changes are necessary to port to Python 3. I'm guessing some of our dependencies will be 2.7+ only.

[gunesacar]

I ran 2to3 on the current master. Issues related to print, unicode, (x)rangeare the overwhelming majority, which can easily be fixed.

But I can't be sure about the other problems, such as requirements without python 3 support (e.g. pyamf, libmproxy).

You can find the patch generated by 2to3 here. Logs are given below:

RefactoringTool: Files that need to be modified:
RefactoringTool: ./demo.py
RefactoringTool: ./automation/BrowserManager.py
RefactoringTool: ./automation/CommandSequence.py
RefactoringTool: ./automation/Errors.py
RefactoringTool: ./automation/MPLogger.py
RefactoringTool: ./automation/SocketInterface.py
RefactoringTool: ./automation/TaskManager.py
RefactoringTool: ./automation/platform_utils.py
RefactoringTool: ./automation/Commands/browser_commands.py
RefactoringTool: ./automation/Commands/command_executor.py
RefactoringTool: ./automation/Commands/profile_commands.py
RefactoringTool: ./automation/Commands/utils/XPathUtil.py
RefactoringTool: ./automation/Commands/utils/domain_utils.py
RefactoringTool: ./automation/Commands/utils/file_utils.py
RefactoringTool: ./automation/Commands/utils/firefox_profile.py
RefactoringTool: ./automation/Commands/utils/lso.py
RefactoringTool: ./automation/Commands/utils/webdriver_extensions.py
RefactoringTool: ./automation/DataAggregator/DataAggregator.py
RefactoringTool: ./automation/DataAggregator/LevelDBAggregator.py
RefactoringTool: ./automation/DeployBrowsers/configure_firefox.py
RefactoringTool: ./automation/DeployBrowsers/deploy_browser.py
RefactoringTool: ./automation/DeployBrowsers/deploy_chrome.py
RefactoringTool: ./automation/DeployBrowsers/deploy_firefox.py
RefactoringTool: ./automation/PostProcessing/Cookie.py
RefactoringTool: ./automation/PostProcessing/build_cookie_table.py
RefactoringTool: ./automation/PostProcessing/post_processing.py
RefactoringTool: ./automation/Proxy/MITMProxy.py
RefactoringTool: ./automation/Proxy/deploy_mitm_proxy.py
RefactoringTool: ./automation/Proxy/mitm_commands.py
RefactoringTool: ./test/conftest.py
RefactoringTool: ./test/expected.py
RefactoringTool: ./test/manual_test.py
RefactoringTool: ./test/openwpmtest.py
RefactoringTool: ./test/test_adblock_plus.py
RefactoringTool: ./test/test_crawl.py
RefactoringTool: ./test/test_custom_function_command.py
RefactoringTool: ./test/test_env.py
RefactoringTool: ./test/test_extension.py
RefactoringTool: ./test/test_profile.py
RefactoringTool: ./test/test_simple_commands.py
RefactoringTool: ./test/test_storage_vectors.py
RefactoringTool: ./test/utilities.py
RefactoringTool: Warnings/messages while refactoring:
RefactoringTool: ### In file ./automation/PostProcessing/Cookie.py ###
RefactoringTool: Line 761: absolute and local imports together

[zackw]

FYI, I have an immediate need for this and, with the exception of mitmproxy (which I may just dike out) I am going to pound on it starting now until it's done. Expect some pull requests in the next couple days.

PyAMF, unfortunately, appears to be dead upstream; it might make sense to maintain a fork under the CITP umbrella.

[dreisman]

mitmproxy support shouldn't be necessary anyway, the latest instrumentation is all done from the browser extension.

[zackw]

Good to know, thanks.

[englehardt]

Python 3 support added in #152.

[zackw]

Yay! Thanks for picking up the ball, Steven. In a couple weeks I will switch my project to use the trunk and let you know how it goes.