Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude log format settings file from update #1573

Closed
J-N-K opened this issue Aug 18, 2023 · 4 comments · Fixed by #1577
Closed

Exclude log format settings file from update #1573

J-N-K opened this issue Aug 18, 2023 · 4 comments · Fixed by #1577

Comments

@J-N-K
Copy link
Member

J-N-K commented Aug 18, 2023

I propose to remove org.apache.karaf.log.cfg from userdata_sysfiles.lst. There is nothing we need to update on a regular basis and it always overwrites custom log format setting on upgrade. @openhab/distro-maintainers WDYT?

@wborn
Copy link
Member

wborn commented Aug 20, 2023

The only issue I see with that is that users that upgrade from OH2 will not be using log4j2.xml

To prevent such issues we could also add some notes on what upgrade paths are supported. Ie. to upgrade from OH n to OH n+2 you first need to upgrade to OH n+1.

That can also become complicated after a while. So some software even have upgrade path tools to compute what versions you need to upgrade through to get to a specific version like GitLab:

https://gitlab-com.gitlab.io/support/toolbox/upgrade-path/

@wborn
Copy link
Member

wborn commented Aug 20, 2023

I see I mistook this file for org.ops4j.pax.logging.cfg but there was probably also something that needed to be changed in this file between certain OH versions.

@J-N-K
Copy link
Member Author

J-N-K commented Aug 20, 2023

The file was changed once in the last five years (to add colored log-messages). I guess we can do the same thing like #1561 if we really need to change it in the future.

@wborn
Copy link
Member

wborn commented Aug 20, 2023

Yes that might work as well. We could also add a DEFAULT command for it in the release where the coloring change was made. That way it still gets updated for users upgrading from those older releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants