[automation] Fully synchronize script action/condition execution if supported by engine #4426
+57
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…implements Lock This moves the locking mechanism added in openhab#4402 to the inheritors of AbstractScriptModuleHandler to synchronize execution context access as well. This fixes the problem thathttps://github.com/openhab/openhab-addons/pull/17510 worked around by using Thread.sleep. Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05
changed the title
florian-h05
added a commit
to florian-h05/openhab-addons
that referenced
this pull request
Oct 26, 2024
…es with UI-based scripts Follow-up for openhab#1710. Depends on openhab/openhab-core#4426. Signed-off-by: Florian Hotze <dev@florianhotze.com>
|
openhab/openhab-addons#17630 can be merged after this PR here has been merged. |
kaikreuzer
added
the
bug
kaikreuzer
pushed a commit
to openhab/openhab-addons
that referenced
this pull request
Oct 26, 2024
…es with UI-based scripts (#17630) Follow-up for #1710. Depends on openhab/openhab-core#4426. Signed-off-by: Florian Hotze <dev@florianhotze.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
ScriptEngineimplementsLock, synchronize the execution of script action/condition.In contrast to #4402, this now synchronizes the full script context access, which setup of execution context, script evaluation and reset of execution context, and not only the script evaluation.
It moves the locking mechanism added in #4402 from
AbstractScriptModuleHandlerto the inheritors ofAbstractScriptModuleHandler.This fixes the bug that openhab/openhab-addons#17510 worked around by using
Thread.sleep.