Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP ServiceAddresses and BaseDistinguishedNames properties show as empty string by default. #105

Open
edtanous opened this issue Sep 23, 2019 · 2 comments
Assignees

Comments

@edtanous
Copy link
Contributor

edtanous commented Sep 23, 2019

GET /redfish/v1/AccountService
Returns the following structure (some keys omitted)

{
    "LDAP": {
        "LDAPService": {
            "SearchSettings": {
                "BaseDistinguishedNames": [
                    ""
                ],
            }
        },
        "ServiceAddresses": [
            ""
        ],
    },
}

ServiceAddresses, and BaseDistinguishedNames default to a single array item with empty string, which is nonsensical. While this will still pass the validator, these should be returning an empty array [] in both cases, when not service address, not distinguished name has been set.

Expected defaults would be

{
    "LDAP": {
        "LDAPService": {
            "SearchSettings": {
                "BaseDistinguishedNames": [],
            }
        },
        "ServiceAddresses": [],
    },
}
@ratagupt
Copy link
Contributor

sure @edtanous

@edtanous
Copy link
Contributor Author

I believe this is still an issue on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants