-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disc Golf icons are bananas #26
Comments
We use the AMENITY_TYPE field to come up with an icon. Do we also need to look at the description? |
Looking at the description would be enough here and I can imagine it being useful in other contexts as well. |
So how do you think we should fix this? |
I haven't had a change to dig through it, but it looks to me like we can just use some heuristics. If the description mentions basket, it's a basket, otherwise use a different icon (A frisbee? a circle? a square? Anything really, it will be more obvious and useful in context if someone were actually trying to use it.) Alternatively, if it mentions a tee we know it's a tee, otherwise it's a basket. Just something to differentiate the two cases. |
maybe this would be of use https://github.com/bevacqua/fuzzysearch |
Another solution is clustering the icons. But that will take some thinking to implement, since we use react-leaflet. @johntyree can you link to some better icons from here? http://thenounproject.com |
@johntyree look at the icons now |
Much better. Would be nice to be able to flip clustering off entirely (should be possible by tweaking zoom level) but this is better than it was, for sure. |
@johntyree at max zoom we disabled clustering, because marker positions were misplaced and it looked kind of funky https://github.com/open-austin/austingreenmap/blob/master/client/js/components/ParkMap.jsx#L110 |
@paulserraino, right, but I'm saying that the problem can manifest before zooming that far, which is hard to detect, so just letting the user toggle it is an easy solution. |
Zilker is pretty overwhelming.
Half of those aren't baskets. They are starting tees.
The text was updated successfully, but these errors were encountered: