Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - making graphql endpoint the default API URL breaks Image component #173

Open
JamesBock opened this issue May 26, 2021 · 0 comments
Open
Labels
bug Something isn't working Dev-Fullstack Size-M

Comments

@JamesBock
Copy link
Collaborator

Using the graphql endpoint as the default API endpoint will cause the Image component to use the wrong url and return 404 for all images because this component calls the REST /image endpoint.

REACT_APP_API_URL: https://api.dev.tenantfile.org/graphql

Remedies (not necessarily mutually exclusive):

  1. Drop graphql from env URL and add it to gql query URLs
  2. Fetch images from the client - Currently, image names are fetched via gql from the server, then the client is passing the names to the server again to the REST endpoint where the server accesses Google Cloud Storage then passes the image to the client. Fetching the images directly on the client seems like a much simpler solution.
@JamesBock JamesBock added bug Something isn't working Dev-Fullstack Size-M labels May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Dev-Fullstack Size-M
Projects
None yet
Development

No branches or pull requests

1 participant