Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Move Transaction Signing on Chain #66

Open
bluesign opened this issue Dec 7, 2021 · 3 comments
Open

FEATURE: Move Transaction Signing on Chain #66

bluesign opened this issue Dec 7, 2021 · 3 comments

Comments

@bluesign
Copy link
Collaborator

bluesign commented Dec 7, 2021

It would be nice to have a feature for multiple signing on chain.

With a contract I think it is possible to ServiceAccount to store payloads and signatures of a transaction in a resource. It can also emit events, about the transaction and signing process.

Benefits:

  • With Crypto API, it is possible to check if signer is allowed to sign. ( though can be extended to allow checking transaction signatures instead of allowing only user signatures, so we can avoid user signatures )

  • With Events this information will stay on chain ( so someone can just query to see what service account did )

  • Initiating transaction can have some Description, final transaction can have transaction ID calculated etc

  • This can be useful for others who want to do multisign ( which is too complicated right now ) But if they can manage to use a Contract to manage, they can do with FCL easily.

  • You can monitor multisign on chain with events. ( Wallets can maybe even notify users when multisign request has been raised )

  • You can enumerate pending multisign transactions with you havent sign yet from chain.

I am curious about your thoughts

@bjartek
Copy link
Collaborator

bjartek commented Dec 7, 2021

I think this is a very good idea. This would also solve the "problem" of having to send contracts back and forth when updating contracts on mainnet.

I especially like the 'wallet can notify user' when a signature request is raised.

@jacob-tucker
Copy link

I'm on board with this as well. Especially as we start to build out DAOs on Flow, it's essential we have easy to use multisig functionality. This could be done in a smart contract.

@bluesign
Copy link
Collaborator Author

Very basic, ~100 lines pop contract https://github.com/bluesign/flow-multisign-vote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants