Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to reflect this readme #127

Open
bjartek opened this issue Oct 11, 2022 · 4 comments
Open

Update docs to reflect this readme #127

bjartek opened this issue Oct 11, 2022 · 4 comments
Assignees

Comments

@bjartek
Copy link

bjartek commented Oct 11, 2022

The following guides do no mention setting the authn.include in order to get dapper wallet to work with standard discovery. This leads to people creating a lot of code for things that could just work out of of the box. Please update

@chasefleming chasefleming self-assigned this Oct 12, 2022
@chasefleming
Copy link
Member

chasefleming commented Oct 12, 2022

@bjartek The original intention was to avoid documentation duplication (repo and portal) by having the overview on portal and specific configuration info on the repo readme, but it sounds like you're saying no one is clicking that link at the bottom. I can definitely see that being the case. Less visible on the repo. Thanks for making this ticket and bringing it up. Let's move the detailed config docs to the portal and just link to the portal documentation from the readme. I can do that.

For the Dapper Wallet technical guides, I've raised that. @chandanworkacct do you know the status on that? Can you tag whoever is responsible for those docs on this issue please? Thanks.

@bjartek
Copy link
Author

bjartek commented Oct 17, 2022

@chasefleming To me it was not obious that I should go into github to check this. The link on developer.flow.com tells you to go to the meetdapper.com link to fix this for dapper but that does not reference the discorvery at all.

@chasefleming
Copy link
Member

@bjartek I'm not seeing the link you're mentioning. Can you link me? I've moved a lot of the config info over to the Wallet Discovery page...what do you think of this? https://developers.flow.com/tools/fcl-js/reference/discovery

@bjartek
Copy link
Author

bjartek commented Oct 24, 2022

I like that you added this docs to the bottom of the page. However further up on the page there is the text:

Note: Opt-in wallets, like Ledger and Dapper Wallet, require you to explicitly state you'd like to use them. For more information on including opt-in wallets, see these docs.

A Dapper Wallet developer account is required. To enable Dapper Wallet inside FCL, you need to follow this guide

And that block of text do not refer to the snippet you added to the bottom of the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants