Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check size of the file before download #156

Closed
volodymyrss opened this issue Mar 20, 2024 · 2 comments · Fixed by #170
Closed

check size of the file before download #156

volodymyrss opened this issue Mar 20, 2024 · 2 comments · Fixed by #170
Assignees

Comments

@volodymyrss
Copy link
Member

volodymyrss commented Mar 20, 2024

if possible to check, dont download above limit.

if not possible, when downloading in chunks, stop at some point.

@burnout87
Copy link
Contributor

I was thinking of introducing a configuration file, using the same approach the dispatcher-app has, what do you think?

It will help in the long term for several other parameters

@volodymyrss
Copy link
Member Author

Maybe, but rather with dynaconf like in oda-bot.
nb2workflow is meant to be used also in command line, so the options should be easy to override from command line, without code duplication.

@burnout87 burnout87 linked a pull request Apr 10, 2024 that will close this issue
@burnout87 burnout87 removed a link to a pull request Apr 26, 2024
@burnout87 burnout87 linked a pull request Apr 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants