catalog as string becomes long unbreakable string

[volodymyrss]

curl "https://www.astro.unige.ch/mmoda/dispatch-data/inspect-state?token=$(cat ~/.oda-token | xargs)&job_id=62840af4b40af6c8" | jq

[volodymyrss]

unclear why catalog is passed as a string. if it was json would be ok. also could use this oda-hub/dispatcher-app#267

also, need to verify why exactly this was not breakable, it's not too bad

[burnout87]

Can you please grant me the role to run this query? I cannot see anything otherwise,

[volodymyrss]

done. We should add a separate role though, in oda-hub/dispatcher-app#263

[burnout87]

unclear why catalog is passed as a string.

When used the functionality Use catalog, the catalog is string-fied by the fontend and passed as string as a whole as argument in the request.

[volodymyrss]

unclear why catalog is passed as a string.

When used the functionality Use catalog, the catalog is string-fied by the fontend and passed as string as a whole as argument in the request.

and in the case of API?

[burnout87]

and in the case of API?

We once wrote a test for indeed testing the catalog sent via the API, and also in that case we passed the catalog as a string.

https://github.com/oda-hub/dispatcher-app/blob/c72ba4763afb9821a9f877d3d9fe06dba5a2b599/tests/test_server_basic.py#L982-L1042

[volodymyrss]

ok then, the test should be expanded to inspect the email.

[burnout87]

Which is exactly what I am working on.

[volodymyrss]

done. We should add a separate role though, in oda-hub/dispatcher-app#263

Note that since I added this role to you, you started to recieved user approval emails. Its circumstantial, it's really Carlo who knows most people who are likely to join, and sometimes you. We should really add a new role.

[burnout87]

done. We should add a separate role though, in oda-hub/dispatcher-app#263

Note that since I added this role to you, you started to recieved user approval emails. Its circumstantial, it's really Carlo who knows most people who are likely to join, and sometimes you. We should really add a new role.

It's ok, I have no problems with that.