Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crop] Replace deprecated vf del #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sneakpeakcss
Copy link

Add remove_last_filter function with additional feedback message

Fixes: #76

Add remove_last_filter function with additional feedback message
dexeonify added a commit to dexeonify/mpv-config that referenced this pull request Jan 13, 2024
Another approach to occivink/mpv-scripts#77
The code for removing the last crop filter is already in toggle_crop(),
I just have to break it down into smaller functions.

Firstly, remove_delogo() is invoked to remove the last delogo filter.
If a delogo filter exists, the function will remove it and return true;
remove_hard() won't be called.
Conversely, if no delogo filter is found, remove_hard() is invoked to
determine the state of video-crop.
Finally, if no delogo filter is present or video-crop is disabled,
toggle_crop() will call start_crop().

The order of crop removal will be made configurable in the next few
commits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'del' has been deprecated
2 participants