Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seek-to.lua Allow Pasting In Timestamps #75

Open
AziRizvi opened this issue Dec 19, 2023 · 5 comments
Open

Seek-to.lua Allow Pasting In Timestamps #75

AziRizvi opened this issue Dec 19, 2023 · 5 comments

Comments

@AziRizvi
Copy link

AziRizvi commented Dec 19, 2023

It'd be great if we could have the ability to paste timestamps using ctrl+v in when the script is activated with its keybind and the osd seek to message is displayed.

@Sneakpeakcss
Copy link

There's a fork made by @dexeonify that implemented this already, and also fixed script crashing when pressing backspace while last digit is selected.

I've also just uploaded my own changes to that fork, that address some of the issues i still had that were either inherited from original seek-to.lua or the fork itself:

  • Shifting message width when selecting pairs of 1's.
  • Selected digit indicator not helping when user uses osd-bold=yes.
  • Not using Ctrl+V for pasting timestamps.

And some other more or less significant changes: seek-to.lua

@AziRizvi
Copy link
Author

There's a fork made by @dexeonify that implemented this already, and also fixed script crashing when pressing backspace while last digit is selected.

I've also just uploaded my own changes to that fork, that address some of the issues i still had that were either inherited from original seek-to.lua or the fork itself:

  • Shifting message width when selecting pairs of 1's.
  • Selected digit indicator not helping when user uses osd-bold=yes.
  • Not using Ctrl+V for pasting timestamps.

And some other more or less significant changes: seek-to.lua

I didn't know about the fork, thanks!
I've gone ahead and grabbed your fork.

@KonoVitoDa
Copy link

@Sneakpeakcss Thanks for the fork! :)
Could I ask for some improvements to it?:

  • Make it possible to paste timestamp while seeker is disabled, like the original fork by @dexeonify
  • Support timestamps formatted as HH.MM.SS.mmm (dots in place colons) for the paste function, so it's easier to copy-paste timestamps taken from screenshots filenames
  • *For files longer than an hour, set the initial cursor position to be in the minutes field
  • *Act like MPC-HC and start the seeker with the current playback time set

The ones I marked with * are kind of personal preferences, but the first two appears to be real improvements. Well, I would be very grateful if you could help me with these points, as I don't have much knowledge to do it myself. 🙏

@Sneakpeakcss
Copy link

@Sneakpeakcss Thanks for the fork! :) Could I ask for some improvements to it?:

* Make it possible to paste timestamp while seeker is disabled, like the original fork by @dexeonify

* Support timestamps formatted as HH.MM.SS.mmm (dots in place colons) for the paste function, so it's easier to copy-paste timestamps taken from screenshots filenames

* *For files longer than an hour, set the initial cursor position to be in the minutes field

* *Act like MPC-HC and start the seeker with the current playback time set

The ones I marked with * are kind of personal preferences, but the first two appears to be real improvements. Well, I would be very grateful if you could help me with these points, as I don't have much knowledge to do it myself. 🙏

Open a feature request in the forked repo and i'll check it out when i have a moment.

@KonoVitoDa
Copy link

Open a feature request in the forked repo and i'll check it out when i have a moment.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants