Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot crop with hwdecoding #42

Open
AeliusSaionji opened this issue Jul 4, 2020 · 2 comments
Open

Cannot crop with hwdecoding #42

AeliusSaionji opened this issue Jul 4, 2020 · 2 comments

Comments

@AeliusSaionji
Copy link

Hello!

Recently updated and noticed you now forcibly disable cropping when hwdecoding is active. While you may not be able to see the effect of your crop in real time, this did in fact work when cropping a video for encode.lua.

Could we exchange the hard-stop for an OSD notice instead?

Thank you!

@UserNaem
Copy link

Use the copy-back version of your hardware decoding method (i.e. hwdec=dxva2-copy instead of hwdec=dxva2) if you need filters, regular hardware decoding typically doesn't allow the use of filters.

@AeliusSaionji
Copy link
Author

You missed the point of my post- I will repeat with emphasis in case it wasn't clear.

I use crop almost exclusively with encode.lua, which passes the crop along to ffmpeg. ffmpeg does not care if mpv used hwdec.
The only downside to having hwdec enabled is that you cannot preview your crop before passing it along to ffmpeg.
That's fine, imo. I'd rather have an error "cannot preview crop with hwdec" than a hard stop on the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants