Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leapp answer command doesn't preserve comments in generated answerfile #606

Open
fernflower opened this issue Feb 11, 2020 · 0 comments
Open

leapp answer command doesn't preserve comments in generated answerfile #606

fernflower opened this issue Feb 11, 2020 · 0 comments
Labels
bug

Comments

@fernflower
Copy link
Member 

[remove_pam_pkcs11_module_check]
# Title:              None
# Reason:             Confirmation
# =================== remove_pam_pkcs11_module_check.confirm ==================
# Label:              Disable pam_pkcs11 module in PAM configuration? If no, the upgrade process will be interrupted.
# Description:        PAM module pam_pkcs11 is no longer available in RHEL-8 since it was replaced by SSSD.
# Type:               bool
# Default:            None
# Available choices: True/False
# Unanswered question. Uncomment the following line with your answer
# confirm =

After leapp answer --section remove_pam_pkcs11_module_check.confirm=True run you get

[remove_pam_pkcs11_module_check]
confirm = True

That happens because configparser in py2 doesn't have a way to preserve comments in ini file. Switch to cfgparse?
@fernflower fernflower added the bug label Feb 11, 2020
fernflower added a commit to fernflower/leapp that referenced this issue Feb 11, 2020
@fernflower
answerfile: introduce answerfile.userchoices
ea2e0fa 
Introduced a persistent between userchoices file that will serve as
a knowledge db for registered user options for a specific dialog.
To register a persistent user choice you can use leapp answer command.

Existing answerfile will be always updated with data from useroptions
file before the workflow.run is called to ensure that users are not
asked twice for the answer to the question they have already answered.

Docs have been updated.

Closes-Bug: oamg#605
Closes-Bug: oamg#606
fernflower added a commit to fernflower/leapp that referenced this issue Feb 11, 2020
@fernflower
answerfile: introduce answerfile.userchoices
76ed50a 
Introduced a persistent between userchoices file that will serve as
a knowledge db for registered user options for a specific dialog.
To register a persistent user choice you can use leapp answer command.

Existing answerfile will be always updated with data from useroptions
file before the workflow.run is called to ensure that users are not
asked twice for the answer to the question they have already answered.

Docs have been updated.

Closes-Bug: oamg#605
Closes-Bug: oamg#606
fernflower added a commit to fernflower/leapp that referenced this issue Feb 13, 2020
@fernflower
answerfile: introduce answerfile.userchoices
51342e6 
Introduced a persistent between userchoices file that will serve as
a knowledge db for registered user options for a specific dialog.
To register a persistent user choice you can use leapp answer command.

Existing answerfile will be always updated with data from useroptions
file before the workflow.run is called to ensure that users are not
asked twice for the answer to the question they have already answered.

Docs have been updated.

Closes-Bug: oamg#605
Closes-Bug: oamg#606
pirat89 pushed a commit that referenced this issue Feb 13, 2020
@fernflower @pirat89
answerfile: introduce answerfile.userchoices
dbc1b81 
Introduced a persistent between userchoices file that will serve as
a knowledge db for registered user options for a specific dialog.
To register a persistent user choice you can use leapp answer command.

Existing answerfile will be always updated with data from useroptions
file before the workflow.run is called to ensure that users are not
asked twice for the answer to the question they have already answered.

Docs have been updated.

Closes-Bug: #605
Closes-Bug: #606
MichalHe pushed a commit to MichalHe/leapp that referenced this issue Aug 12, 2021
@Rezney
Provide also a hint to check if repomap file is up-to-date (oamg#606)
839f27b 
In order to enable upgrades on RHUI we need an updated repomap file.
It can happen users have an old one from previous upgrades and
thus missing the needed mapping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fernflower