Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date and time in utilization sparklines #793

Open
leistnerova opened this issue Oct 2, 2018 · 10 comments
Open

Add date and time in utilization sparklines #793

leistnerova opened this issue Oct 2, 2018 · 10 comments
Labels
Priority: Medium Work on these after the high issues are worked Status: Blocked blocked by something. describe what is blocking it Type: Enhancement an enhancement (i.e. not a bug)

Comments

@leistnerova
Copy link
Collaborator

Utilization sparkline contains current value but not date and time and so it is not obvious what interval is used and e.g. what time was the highest peak to work further with the information.

screenshot from 2018-10-02 14-59-03

@sjd78
Copy link
Member

sjd78 commented Oct 2, 2018

The historic statistics from the REST API do not include timestamps with the data points. So apart from those datapoints somehow being tied to the current date/time (the first data point being the closest half minute past now), there is no way to put date and time stamps on the data points.

Here is an example of the cpu usage history for a VM as returned by the API:

{
  "kind": "gauge",
  "type": "decimal",
  "unit": "percent",
  "values": {
    "value": [
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 4
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      },
      {
        "datum": 3
      }
    ]
  },
  "name": "cpu.usage.history",
  "description": "List of CPU usage history, sorted by date from newest to oldest, at intervals of 30 seconds",
  "id": "bde6d1ed-e07b-3aa1-bfc4-463990f5921a"
}

@leistnerova
Copy link
Collaborator Author

The API result looks strange, 'datum' is czech word for date. I will check that with some developer.

@bond95
Copy link
Contributor

bond95 commented Oct 2, 2018

The API result looks strange, 'datum' is czech word for date. I will check that with some developer.

Datum is singular for data. https://www.gingersoftware.com/english-online/spelling-book/confusing-words/data-datum

@sjd78
Copy link
Member

sjd78 commented Oct 2, 2018

The API result looks strange, 'datum' is czech word for date. I will check that with some developer.

Datum is singular for data.

(from the linguist in me) In Latin for sure, in English "datum" is understood as a single piece of data depending on the specific technical area you're working in. English is strange even for native speakers.

Here is the docs for the statistic type that is from above: http://ovirt.github.io/ovirt-engine-api-model/4.3/#types/statistic

@leistnerova
Copy link
Collaborator Author

Ah :) thanks guys for explanation.

@gregsheremeta gregsheremeta added Type: Enhancement an enhancement (i.e. not a bug) Status: Blocked blocked by something. describe what is blocking it labels Oct 2, 2018
@gregsheremeta
Copy link
Contributor

setting blocked -- would require an API enhancement

@michalskrivanek
Copy link
Member

@gregsheremeta those are fixed intervals, we can say "T-x", estimate would be enough

@sjd78
Copy link
Member

sjd78 commented Oct 3, 2018

those are fixed intervals, we can say "T-x", estimate would be enough

While they are fixed (every 30 seconds), are they always current? The only point in time to count backwards from is the time the data is fetched. I have not tried to drill in to the engine code to figure out that answer. For example, if I stop the VM for awhile and then restart it, what would be the time diffs from now for the historic data set?

@gregsheremeta
Copy link
Contributor

For example, if I stop the VM for awhile and then restart it, what would be the time diffs from now for the historic data set?

Yeah, I think that ruins being able to use this. As we discussed in this morning's meeting, seems like we actually need timestamps on the data points.

@jelkosz @michalskrivanek opinions?

@gregsheremeta gregsheremeta added the Priority: Medium Work on these after the high issues are worked label Jan 6, 2019
@sgratch
Copy link
Member

sgratch commented May 27, 2021

Due to a capacity reason, we won't invest on adding a timestamp on the data points.
We can rather consider adding a tooltip for a general info regarding maximum time range e.g. the information for the last 24 hours...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Work on these after the high issues are worked Status: Blocked blocked by something. describe what is blocking it Type: Enhancement an enhancement (i.e. not a bug)
Projects
None yet
Development

No branches or pull requests

6 participants