Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user settings - confirmation dialog for user settings is missing #1389

Closed
sgratch opened this issue Mar 24, 2021 · 1 comment · Fixed by #1401
Closed

user settings - confirmation dialog for user settings is missing #1389

sgratch opened this issue Mar 24, 2021 · 1 comment · Fixed by #1401
Assignees
@bamsalem
Labels
Status: ON_QA status ON_QA (currently being tested)

Comments

@sgratch
Copy link
Member

sgratch commented Mar 24, 2021

Confirmation dialog for user settings is missing, e.g.: "are you sure you want to make changes to the following settings: language, UI refresh interval."

For more details, check #1088 (comment) (issue 14)
@sgratch
Copy link
Member Author

sgratch commented Mar 30, 2021

Please note that this was already implemented in the original PR but removed, so need to just reuse the existing code. Check with @rszwajko for more details.

@bamsalem bamsalem mentioned this issue Apr 4, 2021
Merged
@sgratch sgratch added the Status: ON_QA status ON_QA (currently being tested) label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bamsalem bamsalem

Labels
Status: ON_QA status ON_QA (currently being tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding confirmation modal on saving user settings changes bamsalem/ovirt-web-ui
2 participants
@sgratch @bamsalem