Selection in VI visual mode need to include the last character (+1 grapheme to the right)

[blindFS]

Platform macOS
Terminal software wezterm

Screen.Recording.2024-10-10.at.18.56.51.mov

This is not what a traditional vim behavior where current character "a" should be included in both directions.
Basically, the end offset returned by get_selection should be increased to the next grapheme.

Steps to reproduce

1. set editor mode to vi
2. press v to visual selection

Seems that crate::core_editor::Editor should be aware of current edit mode in order to fix this issue.

[fdncred]

seems like a reasonable request. i also wish the coloring was maybe just the reverse of whatever the text is. it's so hard to see, but that's a separate issue.

[blindFS]

seems like a reasonable request. i also wish the coloring was maybe just the reverse of whatever the text is. it's so hard to see, but that's a separate issue.

Yes, there's exposed API with_visual_selection_style in engine.rs but never get called in nushell.
Reversed color is a cooler idea.

[fdncred]

nushell/nushell#14052