Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round up swap fee calculation #5

Open
robertleifke opened this issue Jun 29, 2024 · 0 comments
Open

Round up swap fee calculation #5

robertleifke opened this issue Jun 29, 2024 · 0 comments
Assignees
@robertleifke
Labels
enhancement New feature or request
Milestone
Review #2

Comments

@robertleifke
Copy link
Member

Description:

The current implementation of the swap fee calculates the amount using the mulDiv function, so the amounts accrued are rounded down instead of rounded up. Thus, any dust from the calculation is given to the user instead of to the protocol.
@robertleifke robertleifke self-assigned this Jun 29, 2024
@robertleifke robertleifke added the enhancement New feature or request label Jun 29, 2024
@robertleifke robertleifke added this to the Review #2 milestone Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertleifke robertleifke

Labels
enhancement New feature or request
Projects
None yet
Milestone
Review #2
Development

No branches or pull requests
1 participant
@robertleifke