Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce swapping on the curve for users #2

Open
robertleifke opened this issue Jun 29, 2024 · 0 comments
Open

Enforce swapping on the curve for users #2

robertleifke opened this issue Jun 29, 2024 · 0 comments
Assignees
@robertleifke
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
Review #2

Comments

@robertleifke
Copy link
Member

Description:

The greater-than-or-equal condition check instead of an exact equivalence on the pool results in a swap different from implementation of the curve.

Action Items:

  • Produce exact equivalence
  • Fix swap callbacks
@robertleifke robertleifke added bug Something isn't working good first issue Good for newcomers labels Jun 29, 2024
@robertleifke robertleifke added this to the Review #2 milestone Jun 29, 2024
@robertleifke robertleifke self-assigned this Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertleifke robertleifke

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
Review #2
Development

No branches or pull requests
1 participant
@robertleifke