Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/cd: consider exporting some go routines so other projects can ci/cd against notation #22

Open
rchincha opened this issue Nov 23, 2021 · 4 comments
Labels
test any test activities
Milestone

Comments

@rchincha
Copy link

For example,

https://github.com/notaryproject/notation/blob/main/cmd/notation/cert_gen.go

@sajayantony
Copy link
Contributor

Should this issue be in https://github.com/notaryproject/notation-go-lib

@rchincha rchincha changed the title ci/cd: consider making go routines exportable so other projects can ci/cd against notation ci/cd: consider exporting some go routines so other projects can ci/cd against notation Nov 24, 2021
@rchincha
Copy link
Author

notaryproject/notation#141
^ here is a draft PR that could help.
Would be even better if some routines can be pulled out without tying to cli context.

@rchincha
Copy link
Author

Should this issue be in https://github.com/notaryproject/notation-go-lib

^ looks a little low-level for the use case in mind. I would have to re-implement signer and verifier perhaps.

@SteveLasker
Copy link
Contributor

Hi @rchincha,
Thanks for the PR and Issue. We're hoping to keep the CLI focused on core CLI scenarios, with minimal surface area. The functionality you need, should be enabled through the go-libraries. But, this does bring up an interesting point for how the notation plug-ins will work.
I'd like to transfer this to the notation-go-lib for tracking. I'll open an issue related to using plug-ins, when using the notation-go libraries.

@SteveLasker SteveLasker transferred this issue from notaryproject/notation Nov 30, 2021
@dtzar dtzar added this to the future milestone Jul 11, 2022
@priteshbandi priteshbandi modified the milestones: future, Discuss Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test any test activities
Projects
Status: No status
Development

No branches or pull requests

5 participants