Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security consideration section to integration tests #65

Open
jankapunkt opened this issue Nov 14, 2021 · 3 comments
Open

Add security consideration section to integration tests #65

jankapunkt opened this issue Nov 14, 2021 · 3 comments
Labels
hacktoberfest security ❗ Address a security issue tests 🧪 Relates to tests

Comments

@jankapunkt
Copy link
Member

We should add tests to fully cover section 10 - security considerations and cover as much as possible that can be covered without going into implementation details.

@jankapunkt jankapunkt added security ❗ Address a security issue tests 🧪 Relates to tests labels Nov 14, 2021
@jwerre
Copy link
Contributor

jwerre commented Nov 15, 2021

I love this idea. I'm going to outline the tests and push a new security branch to start the discussion.

jwerre added a commit that referenced this issue Nov 15, 2021
@jwerre
Copy link
Contributor

jwerre commented Nov 15, 2021

I created a security branch and started outlining some of the tests here.

This is going to take some time and I'm not sure how much of this is going to be testable without a client but I think it's a good goal. I'll continue to outline the tests and hopefully those will generate some good discussions. Thanks again for bringing this up @jankapunkt

@Uzlopak
Copy link
Collaborator

Uzlopak commented Nov 17, 2021

Actually some interesting stuff. Like the authorization code should not be used multiple times, but if it is then revoke all access tokens based on the authorization code.

So some of these tests mean that we have to store some additional data, like a reference to the authorizationcode (code itself or e.g. a sha1 hash) in the access token) to be able to revoke all access tokens based on that authorization code in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest security ❗ Address a security issue tests 🧪 Relates to tests
Projects
None yet
Development

No branches or pull requests

3 participants