Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve add_header documentation #51

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve add_header documentation #51

wants to merge 1 commit into from

Conversation

crowne
Copy link

@crowne crowne commented Jul 11, 2024 •
edited
Loading

One liner documentation addition

The add_header directive will not generate a header if the value provided is an empty string.

closes #50

y82
y82 requested changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@y82 y82 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @crowne,

Thank you for you patch.

Please note that your statement does not apply to multi-value header fields such as "Cache-Control" and "Link".

Additionally, the corresponding change should also be made for the "add_trailer" directive.

Please ensure the file version bump and commit log style are updated accordingly (see style guide).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y82 y82 y82 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add_header documentation should warn about not sending empty values
2 participants
@crowne @y82