Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make messages in 'Note To Self' chat room take full available screen width #4408

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arkascha
Copy link

๐Ÿ–ผ๏ธ Screenshots

๐Ÿš๏ธ Before ๐Ÿก After
screenshot_befe screenshot_after

DESCRIPTION

This PR implements the change requested in issue #3920.

Messages bubbles in "NoteToSelf" chat room use the full available width now. There is no sense in leaving a start margin, since no other participant can add messages to that chat room.

๐Ÿšง TODO

๐Ÿ Checklist

  • โ›‘๏ธ Tests (unit and/or integration) are included or not needed
  • ๐Ÿ”– Capability is checked or not needed
  • ๐Ÿ”™ Backport requests are created or not needed: /backport to stable-xx.x
  • ๐Ÿ“… Milestone is set
  • ๐ŸŒธ PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

Signed-off-by: Christian Reiner <foss@christian-reiner.info>
โ€ฆNoteToSelf chat

Signed-off-by: Christian Reiner <foss@christian-reiner.info>
@arkascha arkascha changed the title Fix issue 3920: messages in 'NoteToSelf' chat room take full available screen width now Make messages in 'Note To Self' chat room take full available screen width Nov 1, 2024
@arkascha
Copy link
Author

arkascha commented Nov 1, 2024

I fail to understand what the failed analysis is actually trying to say.
I do not see any detail reported by any of the checks that somehow corresponds to my changes.
Is there anything I miss? Anything I need to do, to fix?

@AndyScherzinger AndyScherzinger added the 3. to review Waiting for reviews label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants