From 0e590238bc32dfcacc6b5cf14b0ea1a6282c8560 Mon Sep 17 00:00:00 2001 From: tobiasKaminsky Date: Mon, 2 Dec 2019 09:22:54 +0100 Subject: [PATCH] logging method methods call from constructor should be final Signed-off-by: tobiasKaminsky --- .../owncloud/android/lib/common/operations/RemoteOperation.java | 2 ++ .../android/lib/common/operations/RemoteOperationResult.java | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/owncloud/android/lib/common/operations/RemoteOperation.java b/src/main/java/com/owncloud/android/lib/common/operations/RemoteOperation.java index fe67e0c60..d008e4cf5 100644 --- a/src/main/java/com/owncloud/android/lib/common/operations/RemoteOperation.java +++ b/src/main/java/com/owncloud/android/lib/common/operations/RemoteOperation.java @@ -91,11 +91,13 @@ public abstract class RemoteOperation implements Runnable { */ @Deprecated protected RemoteOperationResult run(OwnCloudClient client) { + Log_OC.d(this, "Not used anymore"); throw new UnsupportedOperationException("Not used anymore"); } protected RemoteOperationResult run(NextcloudClient client) { // Once all RemoteOperation implement it, this should be abstract + Log_OC.d(this, "Not yet implemented"); throw new UnsupportedOperationException("Not yet implemented"); } diff --git a/src/main/java/com/owncloud/android/lib/common/operations/RemoteOperationResult.java b/src/main/java/com/owncloud/android/lib/common/operations/RemoteOperationResult.java index 0837a78d4..f5bd906b0 100644 --- a/src/main/java/com/owncloud/android/lib/common/operations/RemoteOperationResult.java +++ b/src/main/java/com/owncloud/android/lib/common/operations/RemoteOperationResult.java @@ -664,7 +664,7 @@ public String getRedirectedLocation() { return mRedirectedLocation; } - public boolean isIdPRedirection() { + public final boolean isIdPRedirection() { return (mRedirectedLocation != null && (mRedirectedLocation.toUpperCase(Locale.US).contains("SAML") || mRedirectedLocation.toLowerCase(Locale.US).contains("wayf")));