-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cross compile error #3063
Comments
Thanks for this @predators46
Regarding your problem, I don't believe the function calling --- a/sesman/verify_user.c
+++ b/sesman/verify_user.c
@@ -42,8 +42,10 @@
#define SECS_PER_DAY (24L*3600L)
#endif
+#if 0
static int
auth_crypt_pwd(const char *pwd, const char *pln, char *crp);
+#endif
static int
auth_account_disabled(struct spwd *stp);
@@ -184,6 +186,7 @@ auth_check_pwd_chg(const char *user)
return AUTH_PWD_CHG_OK;
}
+#if 0
int
auth_change_pwd(const char *user, const char *newpwd)
{
@@ -292,6 +295,7 @@ auth_crypt_pwd(const char *pwd, const char *pln, char *crp)
return 0;
}
+#endif
/**
* |
there is another problem if doing cross compilation I don't find CC_FOR_BUILD in configure. keygen must cross-compile. Line 23 in 33670ae
|
alpine has patches
|
It's used by I'm wondering if a way round this is to ignore fails if xrdp-keygen during install, but to run it when the xrdp service is started if the file doesn't exist. Presumably you're having to write a service script for OpenWRT to handle xrdp? |
This patch should let the build run through without an rsakeys.ini being generated:- --- a/keygen/Makefile.am
+++ b/keygen/Makefile.am
@@ -20,7 +20,7 @@ xrdpsysconfdir = $(sysconfdir)/xrdp
install-data-hook:
umask 077 && \
if [ ! -f $(DESTDIR)$(xrdpsysconfdir)/rsakeys.ini ]; then \
- ./xrdp-keygen xrdp $(DESTDIR)$(xrdpsysconfdir)/rsakeys.ini; \
+ ./xrdp-keygen xrdp $(DESTDIR)$(xrdpsysconfdir)/rsakeys.ini || : ; \
fi && \
if [ ! -f $(DESTDIR)$(xrdpsysconfdir)/cert.pem ]; then \
$(OPENSSL) req -x509 -newkey rsa:2048 -sha256 -nodes \ |
thank you I understand now |
Let me know how you get on - this definitely falls into the 'interesting' category of PRs! We might want to add a way to disable the compile-time generation of |
in openwrt to cross compile you have to build the host first. i can cross compile but xrdp needs openssl host while building xrdp as host but OpenWrt doesn't add host package in openssl so for the time being, I created rsakeys.ini on my local machine. is there a way to disable openssl in xrdp while building? i can cross compile if xrdp doesn't need openssl currently I managed to build xrdp without rsakeys.ini when building xrdp. |
I think that openssl is only used on |
I see openssl is required when building xrdp |
Yes - the libraries are. You'll need those in your build environment. We've looked into using other ssl libraries when all the fuss started over openssl maintenance, but in the end we didn't implement any changes apart from the migration to the EVP interface for OpenSSL 3.0. |
maybe add --disable-openssl |
We need some sort of SSL library to provide RDP over TLS which is pretty mandatory these days. Is there anything that works better for you than openSSL in your environment? |
I haven't tried again. i don't have access to my virtual machine on linode |
xrdp version
0.9.25.1
Detailed xrdp version, build options
Operating system & version
OpenWrt aarch64
Installation method
other
Which backend do you use?
No response
What desktop environment do you use?
OpenWrt
Environment xrdp running on
No response
What's your client?
No response
Area(s) with issue?
Other
Steps to reproduce
✔️ Expected Behavior
No response
❌ Actual Behavior
2024-05-06T23:00:39.0737006Z verify_user.c:221:9: error: implicit declaration of function 'putpwent'; did you mean 'getpwent'? [-Werror=implicit-function-declaration]
2024-05-06T23:00:39.0738444Z 221 | putpwent(spw, fd);
2024-05-06T23:00:39.0738972Z | ^~~~~~~~
2024-05-06T23:00:39.0739399Z | getpwent
2024-05-06T23:00:39.1114725Z cc1: all warnings being treated as errors
Anything else?
No response
The text was updated successfully, but these errors were encountered: