Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Update IRASA #234

Open
ryanhammonds opened this issue Jan 11, 2021 · 0 comments
Open

[ENH] Update IRASA #234

ryanhammonds opened this issue Jan 11, 2021 · 0 comments
Labels
enhancement Potential enhancements, not specified to a particular release.

Comments

@ryanhammonds
Copy link
Member

In the IRASA paper, the algorithm section notes that they split the signal into 10 overlapping segments of 90% of the signal, run IRASA on each segment, then average the resulting psd and psd_aperiodic across segments. The current IRASA implementation in neurodsp doesn't segment the signal. This may be worth adding. Kwargs for n_segs and seg_fract could be added so n_segs=1 and seg_fract=1 would produce the same results as the current implementation, while n_segs=10 and seg_fract=.1 would reproduce the paper's algorithm.

@TomDonoghue TomDonoghue added the enhancement Potential enhancements, not specified to a particular release. label Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Potential enhancements, not specified to a particular release.
Projects
None yet
Development

No branches or pull requests

2 participants