Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate batched/non-batched operations in Metric #498

Open
odashi opened this issue Sep 19, 2022 · 0 comments
Open

Separate batched/non-batched operations in Metric #498

odashi opened this issue Sep 19, 2022 · 0 comments

Comments

@odashi
Copy link
Contributor

odashi commented Sep 19, 2022

Metric is implemented for both batched/non-batched operations and it is very annoying to organize overall behavior around Metric. Most functions need to switch its behavior with given argument, and it looks some functions involves untested bugs with unclear operations (e.g., the caller expects to return ndarray of shape [], but the function returns [1]).

It is better to implement Metric to calculate scores for only non-batched data, and operations for batched data should be synthesized from non-batched operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant