Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: DMF: Generation of ChangeLog depends on presence of master branch in index #2551

Open
jimklimov opened this issue Jul 23, 2024 · 1 comment
Labels
bug CI Entries related to continuous integration infrastructure (historically also recipes like Makefiles) documentation
Milestone

Comments

@jimklimov
Copy link
Member

jimklimov commented Jul 23, 2024

Common ChangeLog starting point is tag v2.6.0 which is available among other tags in CI builds. The branches however are pulled on a need-to-know basis, so PRs only have their source and target, e.g.

$ git branch -a
* (detached from 1a60b39)
  remotes/origin/FTY
  remotes/origin/PR-2544

DMF recipes were changed to show log differences from a master branch to current DMF/FTY codebase instead. However, in non-persistent workspaces the branch is not known:

$ git checkout master
error: pathspec 'master' did not match any file(s) known to git.
fatal: ambiguous argument 'master..HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
  DOC-CHANGELOG-ASCIIDOC	SKIP: FAILED to resolve input or output filename with this make implementation, or input was not generated!

The solution is probably to also build DMF/FTY ChangeLog starting from a tag, whether fixed or e.g. latest NUT release now that we update the branch often, heading towards full merge per #1316.

Note that this is not a very pressing issue, since the majority of practically useful complete builds are done either from the master branch iterations, or with PR's aiming to merge into it, so the branch is usually known to CI agents.

@jimklimov jimklimov added this to the 2.8.4 milestone Jul 23, 2024
jimklimov added a commit to networkupstools/jenkins-dynamatrix that referenced this issue Jul 25, 2024
…even if we are not building it

Should address networkupstools/nut#2551

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
@jimklimov jimklimov added the CI Entries related to continuous integration infrastructure (historically also recipes like Makefiles) label Jul 30, 2024
@jimklimov
Copy link
Member Author

Note: similar issue noted with work on gitlog2version.sh. It goes to some extremes to find the newest TRUNK among known git remotes that might have a variant of master history cached in the local index, if one to use was not specified explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug CI Entries related to continuous integration infrastructure (historically also recipes like Makefiles) documentation
Projects
None yet
Development

No branches or pull requests

1 participant