Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise and "backport" driver fixes from 42ITy fork #1108

Closed
jimklimov opened this issue Sep 25, 2021 · 1 comment
Closed

Revise and "backport" driver fixes from 42ITy fork #1108

jimklimov opened this issue Sep 25, 2021 · 1 comment

Comments

@jimklimov
Copy link
Member

There was a fair amount of both cross-pollination and independent evolution between "upstream" NUT project and 42ITy fork at https://github.com/42ity/nut/commits/FTY over the past years. Many PRs were developed in one and ported to another shortly, others were double-posted, but not all.

In particular, the fork pioneered many Eaton/MGE/PowerWare driver fixes (USB HID, SNMP, NetXML), some in logic, some in mapping data, not all of which landed into the upstream yet -- at least, some of those sources do differ "substantially" (there are also differences due to style and warnings clean-up in the "upstream" NUT, and some due to other features developed in 42ITy such as the DMF feature).

Ideally, those changes should be cherry-picked to retain the original authorship and time references, which in many cases would mean conflict resolution and constraining the change-sets to just what impacts the drivers AND what did not make way into the modern state of upstream NUT by some other path.

@jimklimov
Copy link
Member Author

Largely (fully?) addressed by #1319 and can be seen as subset of #1316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant