Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in all parcellation-specific null models #3

Open
rmarkello opened this issue Jul 20, 2021 · 1 comment
Open

Bug in all parcellation-specific null models #3

rmarkello opened this issue Jul 20, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@rmarkello
Copy link
Member

The following line is present in all parcellation-specific null models (i.e., nulls.vasa, nulls.hungarian, nulls.baum, and nulls.cornblath):

https://github.com/netneurolab/brainnotation/blob/09ef3c88270f85d97de83d69e51cb6917e21f417/brainnotation/nulls/nulls.py#L190

But it should be the opposite (i.e., if parcellation is None). Currently all of these functions are useless 😬 Should be an easy fix, though!

(h/t to @danjgale for pointing this out)
@rmarkello rmarkello added the bug Something isn't working label Jul 20, 2021
@rmarkello
Copy link
Member Author

Hypothetically fixed with the mess of a PR that was #5. Gonna leave this open 'till I add some tests to confirm, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmarkello