Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Changing a NodeType type doesn't get marked as "changed" #4191

Open
dlubitz opened this issue Apr 14, 2023 · 3 comments · May be fixed by #5320
Open

BUG: Changing a NodeType type doesn't get marked as "changed" #4191

dlubitz opened this issue Apr 14, 2023 · 3 comments · May be fixed by #5320
Assignees
@nezaniel
Labels
9.0 Bug
Milestone
9.0 (ES CR)

Comments

@dlubitz
Copy link
Contributor

dlubitz commented Apr 14, 2023

If you change the type of a NodeType the workspace doesn't get marked as "changed". So you are not able to publish this particular change without changing something else.

As in the new CR nodes are consistently typed across variants there are some open questions to clarify:

  • How shall we mark this change as "changed" without having a dimension space point for this change
  • Does it make sence to mark all dimension space points as "changed"?
  • How does publishing than work? Do I need to publish each dimension space point or just one to get this change published?
  • How do we deal with permissions if a user has e.g. permissions for language A but not for language B?

See also: https://neos-project.slack.com/archives/C3MCBK6S2/p1681472294867779
@dlubitz dlubitz mentioned this issue Apr 14, 2023
Closed
1 task
@skurfuerst skurfuerst added this to the 9.0 (ES CR) milestone Apr 14, 2023
@mhsdesign
Copy link
Member

cc @nezaniel this might be also interesting to you ;)

@nezaniel
Copy link
Member

yep, that's the next elephant on my list (and the last element on my testing graph)

@dlubitz dlubitz assigned dlubitz and nezaniel and unassigned dlubitz Sep 13, 2024
@kitsunet
Copy link
Member

Weirdly the described problem no longer exists. A change is triggered on changing the nodetype, however, discarding the change does not reset the nodetype to it's previous state.

@nezaniel nezaniel linked a pull request Oct 23, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nezaniel nezaniel

Labels
9.0 Bug
Projects
Neos 9.0 Release Board
Status: Prioritized 🔥
Milestone
9.0 (ES CR)
Development

Successfully merging a pull request may close this issue.

!!! 4191 - Adjust and test node type change behavior neos/neos-development-collection
5 participants
@skurfuerst @kitsunet @nezaniel @dlubitz @mhsdesign