Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrapyd v1.5 breaks jobs view (Oops! Something went wrong) #238

Open
giido opened this issue Oct 6, 2024 · 2 comments
Open

scrapyd v1.5 breaks jobs view (Oops! Something went wrong) #238

giido opened this issue Oct 6, 2024 · 2 comments

Comments

@giido
Copy link

giido commented Oct 6, 2024

Describe the bug
Do to this change in v1.5.0 the regex here (https://github.com/my8100/scrapydweb/blob/8de7ede6fe317e3ef1688572c5a0e8112cc3232f/scrapydweb/views/dashboard/jobs.py#L99C9-L99C83) does not pass and therefore the jobs view results in the error: Oops! Something went wrong.

if status_code != 200 or not re.search(r'<body><h1>Jobs</h1>', self.text):

Fix
Change the regex from <body><h1>Jobs</h1> to <body>\s*<h1>Jobs</h1>

Additional context
I will add a pull request when I get more time and learn how to make one :)
@my8100
Copy link
Owner

my8100 commented Oct 6, 2024 •
edited
Loading

Thanks for your feedback.
Scrapyd v1.5.0 was released recently and may introduce many changes.
I will conduct a thorough test with it.

@my8100
Copy link
Owner

my8100 commented Oct 7, 2024

Fixed in scrapydweb v1.5.1, pls have a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giido @my8100