-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AddressSanitizer: heap-buffer-overflow in filter_and_add sd_ass.c:379 #15086
Comments
@Dudemanguy any idea on this one. pinging you since you were the last one looking at that part of the code, i believe. |
Not sure about this one. Seems like an obscure race of sorts? It looks like you manage to hit the redecode path while quitting which shouldn't matter but something is going wrong somewhere. The packet is detected as seen which means it should have been been added Although we are probably redecoding packets more than necessary now that I look at this again. |
Not a fix but with #15094, the code path you took to trigger this crash won't happen anymore for the vast majority of files. |
mpv Information
Other Information
Reproduction Steps
https://github.com/mpv-player/mpv/blob/master/sub/sd_ass.c#L379
Expected Behavior
No crash
Actual Behavior
Crash
Log File
crash.log
Sample Files
N/A
I carefully read all instruction and confirm that I did the following:
--log-file=output.txt
.The text was updated successfully, but these errors were encountered: