Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept header parsing is too strict. #147

Open
kirelagin opened this issue Dec 17, 2021 · 0 comments
Open

Accept header parsing is too strict. #147

kirelagin opened this issue Dec 17, 2021 · 0 comments

Comments

@kirelagin
Copy link

Current implementation only recognises application/json, however the format of the Accept header is more flexible.

For example, the http client library that I am using is setting it to application/json;charset=utf-8,application/json and, as a result I am getting an HTML response. I worked this around by querying the /json endpoint for now.

Test:

$ curl -H 'User-Agent: something' -H 'Accept: application/json;charset=utf-8,application/json' http://ifconfig.co:80/
<!DOCTYPE html>
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kirelagin