Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fp32 #57

Open
viyjy opened this issue Aug 11, 2023 · 1 comment
Open

fp32 #57

viyjy opened this issue Aug 11, 2023 · 1 comment

Comments

@viyjy
Copy link

viyjy commented Aug 11, 2023

Hi, thanks for this great work.
I have a question regarding encode_latents_in_fp16. If we set encode_latents_in_fp16=False to use fp32, do we expect lower performance compared to fp16? I have tried both and found that images generated by fp32-based model have lower quality than fp16-based model. Is that expected? Thanks

Best
@Landanjs
Copy link
Contributor

Hi, how much worse is the quality? Do you have examples?

We haven't checked this ourselves, but it is possible that the VAE quality at fp32 could be worse if the VAE was trained on fp16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@viyjy @Landanjs