Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Allow self signed certificates #805

Closed
NotExpectedYet opened this issue Mar 17, 2023 · 3 comments · Fixed by #913
Closed

[Feature Request] Allow self signed certificates #805

NotExpectedYet opened this issue Mar 17, 2023 · 3 comments · Fixed by #913
Labels

Comments

@NotExpectedYet
Copy link

NotExpectedYet commented Mar 17, 2023

Is your feature request related to a problem? Please describe.
I can't connect to my local proton mail instance without allowing self signed certificates as the protonmail bridge wraps all connections in them.

Describe the solution you'd like
A little tick box in the UI would be nice to ignore/accept self signed certificates

Describe alternatives you've considered
Not entirely sure what I could do to work around this in this configuration

Additional context
I'm using a local installation of Proton Mail - Bridge. This is running on docker with ports 25 and 143 exposed externally.

@firstof9
Copy link
Collaborator

You'd need to load your CA cert into the HA container each update in order to get this to work.
This is out of the scope of the integration.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the no-issue-activity Stale issue label Mar 28, 2023
@github-actions github-actions bot closed this as completed Apr 3, 2023
@AngellusMortis
Copy link

AngellusMortis commented Jun 19, 2024

imaplib allows passing SSL context, which can skip cert validation. You can add a checkbox to allow the user to not verify the SSL cert. This is very common in HA integrations since it is very likely for people to use self-signed certs for various reasons locally.

This is the only way to connect to Proton Mail via IMAP since everything is E2E encrypted. It is hard to find to market share numbers since providers do not regularly post how many users they have, but Proton Mail is likely the 4th or 5th largest email provider now. Either right behind or before Yahoo! mail, but still behind Gmail, Outlook and Apple.

Supporting Proton is better than not supporting it. Unverified SSL checks are better than not supporting and/or not using SSL at all.

@firstof9 firstof9 linked a pull request Jun 19, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants