-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve URI monero_wallet
standard by allowing optional <txid> string
#729
Comments
Some great use cases for scan_tx (insta syncing a one-time-use gift wallet with 1 input -> to be transferred to the users own wallet via magic - ideally from a trusted node) Sidenote: theres a bit of a bug with scan_tx where duplicates can be scanned and appear in your history list as amount "0" - probably causes issues elsewhere, jberman has a PR fixing it here monero-project/monero#8566 |
1 txid , or a list separated by commas is easy to work with. proof of concept here https://github.com/plowsof/redeem_gift_poc edit* this pull request to add multiple recipients to a payment uri uses ";" so for consistency txid should also monero-project/monero#8665 |
I believe it's ready for final review now @luigi1111 |
@luigi1111 Cake Wallet is implementing the URI standard as written above, which deviates somewhat from the listed version in the wiki. |
Should the wiki be updated? |
to get this moving along, this needs to be a pull request to the actual wiki, then it can be reviewed conveniently before merging. thanks @SamsungGalaxyPlayer for this 🥇 ( @ofrnxmr (?) pointed out that connecting to a node as --trusted-daemon reduces network usage. in my PoC i found it reduced the time to claim a gift card from 18s to around 8s~ ) |
@plowsof how can I open a pull request for the wiki? I haven't done that before |
@SamsungGalaxyPlayer sorry, the feature does not exist, removes foot from mouth will ask around what the best course of action here is |
@SamsungGalaxyPlayer a suggestion was to make a PR to https://github.com/monero-project/meta/tree/master/api (adding a file called something like uri_formatting.md inside the api folder) because we can't make PRs/review @ the wiki |
Well Cake is going forward with the standard above. If Core wants to update the wiki page to match this, only they can edit that page as far as I understand @luigi1111 @plowsof |
https://github.com/monero-project/monero/wiki/URI-Formatting/_history isn't only Core, but I don't know off-hand how to do it (for non-maintainers). |
We locked the wiki because people would add nonsense / malicious links. |
I will re-open with changes. Our devs have advised me, and I've learned more about URIs in the process. |
Current Monero URI documentation: https://github.com/monero-project/monero/wiki/URI-Formatting#wallet-definition-scheme
There is a Monero gift card project that could benefit from including txids in the URI, now that
scan_txid
is available.Proposal
At a minimum, a
monero_wallet
URI requires one ofseed
or(view_key,address)
. Additional parameters are useful to enable spending (seed
enables spends;view_key
withoutspend_key
does not) and for efficiency purposes.address
view_key
spend_key
address
,view_key
view_key
address
, absence ofseed
view_key
is provided but aspend_key
is not provided, then the wallet will be view-only.seed
view_key
height
txid
height
may be provided.txid
height
;
.Example 1:
Example 2:
Example 3:
Legacy and Inconsistencies
mnemonic_seed
andseed
as interchangeable. Good wallet code should accept eitherseed
ormnemonic_seed
for theseed
parameter.address=
was not required if the address was provided directly aftermonero_wallet:
. Good wallet code should account for this possibility.Context/Use
There is a desire to use Monero "gift cards" with a small preloaded value on them. In situations where these cards are loaded in a single transaction, wallets can easily and near-instantly scan specific txids, for then sweeping into another seed automatically.
If only a restore height is specified, then scanning can take minutes or hours.
Scanning a monero_wallet URI with specific txids signals to the wallet that the only funds in this seed are from these specific txids.
This field serves 2 purposes:
Questions
Changelog
The text was updated successfully, but these errors were encountered: