-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Java3D import #1142
Comments
I just made a brief try at updating the 3D Viewer to use the JogAmp Java 3D 1.7.2. I was thinking I could upload the new Java 3D JARs, while leaving the old ones in place as well (different package prefixes, so they do not clash). But I wanted to check whether they were really a drop-in replacement apart from the package prefixes, and what I found is not quite. I pushed a branch with the needed changes, which does not compile due to a couple of differences:
So the short answer is NO, even if we uploaded the new JogAmp Java 3D JARs immediately, I suspect you would run into some compilation errors as well. Did you try it yet? If everything compiles and works for you—or if you have time to quickly fix any problems you encounter—then I'm certainly willing to upload the JogAmp Java 3D JARs to support you, rather than you needing to ship them yourself. |
@ctrueden thank you very much for having a look! I don't understand what I could do now next, because the compilations issues that you describe above appear to be related to upstream code, isn't it? |
@ctrueden If I would do this today, would this would this work within Fiji, or would I need to ship the
org.jogamp.java3d:java3d-core:1.7.2
via my update site (since it is not yet in Fiji)?The text was updated successfully, but these errors were encountered: