-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse-render loop creates newline #198
Comments
Hi @nschloe, the behavior you describe seems to be intentional, or say "by-design" to me. It is the class Document(BlockToken):
"""
Document token.
This is a container block token. Its children are block tokens - container or leaf ones.
Attributes:
footnotes (dictionary): link reference definitions.
"""
def __init__(self, lines):
if isinstance(lines, str):
lines = lines.splitlines(keepends=True)
lines = [line if line.endswith('\n') else '{}\n'.format(line) for line in lines]
# ... I'm not sure if this should be / can be safely changed. So closing for now, but feel free to reopen this issue if needed. |
Not sure why you put in this workaround. The only situation I could imagine where it does anything is to append a missing terminal I'd always expect a parse-render loop to stay as faithful to the input as possible, unless it's illegal input; error out then. What's your take on this? |
Yeah, I'm not sure either why this was introduced by the original author 5 years ago. As you write, this could possibly deserve some investigation, so I'm reopening this... |
MWE:
Output:
'a\n'
Expected output:
'a'
The text was updated successfully, but these errors were encountered: